[#396] Batch TradingWidget RPC calls + reduce polling#398
Merged
realproject7 merged 1 commit intomainfrom Mar 20, 2026
Merged
Conversation
Combine balance + estimate queries into a single multicall request (2 individual calls → 1 RPC request). Reduce polling from 15s to 60s. Estimate only fetched when amount is entered (no idle polling). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 20, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
LGTM. Balance + estimate combined into single multicall, polling reduced from 15s to 60s, estimate conditionally included. CI green.
project7-interns
approved these changes
Mar 20, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR matches issue #396: TradingWidget now batches balance and estimate into one multicall, only includes the estimate call when an amount is present, and reduces polling to 60 seconds. The required lint/typecheck check is green.
Findings
- None.
Decision
Approve because the implementation is focused, follows the accepted browser client pattern, and satisfies the issue acceptance criteria.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
multicallRPC request (2 individual calls → 1)refetchTradeData()Fixes #396
Test plan
npm run typecheck— passesnpm run lint— passes🤖 Generated with Claude Code